on.nemtina/persistence
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

featute/ChangeLog #6

Merged
on.nemtina merged 25 commits from featute/ChangeLog into master 2024-12-09 17:44:48 +05:00
Conversation 0 Commits 25 Files Changed 42 +8 -4
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f647afcd53 - Show all commits

8
Persistence.Repository/QueryBuilders.cs
View File

@ -10,7 +10,7 @@ namespace Persistence.Repository;
/// </summary> /// </summary>
public static class QueryBuilders public static class QueryBuilders
{ {
public static void Apply<TEntity>(this IQueryable<TEntity> query, SectionPartRequest request) public static IQueryable<TEntity> Apply<TEntity>(this IQueryable<TEntity> query, SectionPartRequest request)
where TEntity : class, IWithSectionPart where TEntity : class, IWithSectionPart
{ {
if (request.IdSection.HasValue) if (request.IdSection.HasValue)
@ -25,9 +25,11 @@ public static class QueryBuilders
{ {
query = query.Where(e => e.DepthEnd <= request.DepthEnd); query = query.Where(e => e.DepthEnd <= request.DepthEnd);
} }
return query;
} }
public static void Apply<TEntity>(this IQueryable<TEntity> query,DateTimeOffset momentUtc) public static IQueryable<TEntity> Apply<TEntity>(this IQueryable<TEntity> query,DateTimeOffset momentUtc)
where TEntity : class, IChangeLog where TEntity : class, IChangeLog
{ {
momentUtc = momentUtc.ToUniversalTime(); momentUtc = momentUtc.ToUniversalTime();
@ -35,6 +37,8 @@ public static class QueryBuilders
query = query query = query
.Where(e => e.Creation <= momentUtc) .Where(e => e.Creation <= momentUtc)
.Where(e => e.Obsolete == null || e.Obsolete >= momentUtc); .Where(e => e.Obsolete == null || e.Obsolete >= momentUtc);
return query;
} }

4
Persistence.Repository/Repositories/ChangeLogRepository.cs
View File

@ -139,8 +139,8 @@ public class ChangeLogRepository : IChangeLogRepository
CancellationToken token) CancellationToken token)
ng.frolov commented 2024-12-05 13:47:36 +05:00
Outdated
Review
Copy Link
private IQueryable<ChangeLog> MakeReadQuery(Guid idDiscriminator, DateTimeOffset momentUtc){...}
private IQueryable<ChangeLog> ApplyFilter(IQueryable<ChangeLog> query,  SectionPartRequest request){...}

"Build" - намекает на наличие билдера, а его нет. (можно подумать чтобы его завести:))

``` private IQueryable<ChangeLog> MakeReadQuery(Guid idDiscriminator, DateTimeOffset momentUtc){...} private IQueryable<ChangeLog> ApplyFilter(IQueryable<ChangeLog> query, SectionPartRequest request){...} ``` "Build" - намекает на наличие билдера, а его нет. (можно подумать чтобы его завести:))
👍 1
{ {
var query = CreateQuery(idDiscriminator); var query = CreateQuery(idDiscriminator);
query.Apply(momentUtc); query = query.Apply(momentUtc);
query.Apply(filterRequest); query = query.Apply(filterRequest);
ng.frolov commented 2024-12-05 13:51:47 +05:00
Outdated
Review
Copy Link

Мы не доверяем пользователям и все равно приводим к UTC

Мы не доверяем пользователям и все равно приводим к UTC
👍 1
var result = await query.ApplyPagination(paginationRequest, Convert, token); var result = await query.ApplyPagination(paginationRequest, Convert, token);